Opened 3 years ago

Closed 3 years ago

#13207 closed Task (fixed)

Use modal window to display help in toolbar configurator

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.5.0
Component: Toolbar Configurator Version: 4.5.0 Beta
Keywords: Cc:

Description


Change History (7)

comment:1 Changed 3 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 3 years ago by Olek Nowodziński

Status: assignedreview

Changes in branch:t/13207 and corresponding branch in samples-framework.

comment:3 Changed 3 years ago by Piotrek Koszuliński

Status: reviewreview_failed
  1. The PicoModal license must be included - both in the samples framework and in the ckeditor-dev. If you do the 2nd point, then samples framework will be ok. In ckeditor-dev we must reorganise licenses and I'll report a separate ticket for this.
  2. I think that we should install PicoModal using npm in samples-framework. For many reasons such as easy upgrading, having access to source code and keeping a right license there.

comment:4 Changed 3 years ago by Piotrek Koszuliński

I pushed one more commit to t/13207 in samples-framework and rebased t/13207 in ckeditor-dev.

comment:5 Changed 3 years ago by Olek Nowodziński

Thanks R. I'll go back to this task once I'm done with high priority issues.

comment:6 Changed 3 years ago by Olek Nowodziński

Status: review_failedreview

Updated both branches:

  • Used picomodal from npm.
  • Updated SF docs.
  • Updated ckeditor-dev gruntfile.
  • Compiled new sf.js file.

In ckeditor-dev we must reorganise licenses and I'll report a separate ticket for this.

Waiting for feedback regarding this comment.

comment:7 Changed 3 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Merged to major with git:3b624b6 and to master in samples-framework: https://github.com/cksource/samples-framework/commit/965cec75c0d

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy