Opened 12 years ago

Closed 12 years ago

#1322 closed New Feature (invalid)

Speed up load by eliminating document.write

Reported by: Matthias Miller Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

I've been profiling FCKeditor with Firebug to see if I can improve its load time. The construction of all of the FCKPanel's in the default sample takes 100ms in Firefox, and it can be reduced to 50ms by eliminating the document.write (see patch).

I did notice #515, which may prove this approach to be unusable.

Attachments (1)

document-write.patch (2.0 KB) - added by Matthias Miller 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Matthias Miller

Attachment: document-write.patch added

comment:1 Changed 12 years ago by Matthias Miller

To provide a point of reference, this change takes the total JavaScript time from 250ms to 200ms (20% less).

comment:2 Changed 12 years ago by Matthias Miller

Apologies. It looks like this patch is completely broken. You cannot set the document's HTML by setting oIFrame.src via JavaScript.

comment:3 Changed 12 years ago by Matthias Miller

Clarification: Setting an IFRAME's HTML using the src property is asynchronous, which breaks many assumptions regarding FCKPanel.

comment:4 Changed 12 years ago by Frederico Caldeira Knabben

Resolution: invalid
Status: newclosed

Most probably the synchronous behavior of document write is making that function a bit slower, but as you have noted we need the iframe DOM ready for interaction right after its creation.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy