Opened 9 years ago
Closed 9 years ago
#13300 closed Bug (fixed)
The internalCommit argument in the image dialog seems to be totally unused
Reported by: | Piotrek Koszuliński | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 |
Component: | General | Version: | 3.0 RC |
Keywords: | Cc: |
Description
The argument was added in #4246, because there's nothing about it in:
http://dev.ckeditor.com/browser/CKEditor/trunk/_source/plugins/image/dialogs/image.js?rev=4684
and plenty of it here:
http://dev.ckeditor.com/browser/CKEditor/trunk/_source/plugins/image/dialogs/image.js?rev=4686
For all these years I thought that it serves some purpose, but I cannot find any. In our tests and the one I performed manually commit()
is never called with more arguments than two. Therefore I propose to remove these lines.
There's still a small chance that someone (perhaps some external plugin, because none of ours seem to rely on this argument either) uses this argument, so I propose to make this change in 4.5.0.
Change History (1)
comment:1 Changed 9 years ago by
Milestone: | → CKEditor 4.5.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Version: | → 3.0 RC |
Fixed on major with git:10a7105.