Opened 4 years ago

Closed 4 years ago

#13400 closed Bug (fixed)

Improvements for fix for #13334

Reported by: Piotrek Koszuliński Owned by: Szymon Cofalik
Priority: Normal Milestone: CKEditor 4.5.0
Component: General Version: 4.5.0
Keywords: Cc:

Description

I don't like one thing in #13334 - the length of findOneNotNested. The reason why it got so long is that it uses getParents() instead of getAscendant(). And instead of adding next param to getParents() I think we can add it to getAscendant().

Change History (4)

comment:1 Changed 4 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.5.1CKEditor 4.5.0
Status: newconfirmed

comment:2 Changed 4 years ago by Szymon Cofalik

Tweaked on branch:t/13400.

comment:3 Changed 4 years ago by Szymon Cofalik

Owner: set to Szymon Cofalik
Status: confirmedreview

comment:4 Changed 4 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Fixed on major with git:5c2bd9c.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy