Opened 4 years ago

Closed 3 years ago

#13419 closed Bug (fixed)

Autolink should encode href.

Reported by: Piotrek Koszuliński Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.5.2
Component: General Version: 4.5.0 Beta
Keywords: Cc:

Description

  1. Open http://tests.ckeditor.dev:1030/tests/plugins/autoembed/manual/autoembed
  2. Paste http://foo.com/bar"bom
  3. Check the source - the link's href should be http://foo.com/bar"bom

Note: The content content of a text inside dataValue is already encoded, so the only character we need to encode is ".

Change History (5)

comment:1 Changed 3 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 3 years ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:3 Changed 3 years ago by Tade0

Status: assignedreview

Shouldn't it rather be "http://foo.com/bar%22bom"?

Pushed an implementation in which the quotation marks are urlencoded in the href to branch:t/13419.

comment:4 Changed 3 years ago by Olek Nowodziński

Status: reviewreview_passed

comment:5 Changed 3 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged git:e235295 into master.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy