Opened 11 years ago

Closed 11 years ago

#13419 closed Bug (fixed)

Autolink should encode href.

Reported by: Piotrek Koszuliński Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.5.2
Component: General Version: 4.5.0 Beta
Keywords: Cc:

Description

  1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/autoembed/manual/autoembed
  2. Paste http://foo.com/bar"bom
  3. Check the source - the link's href should be http://foo.com/bar"bom

Note: The content content of a text inside dataValue is already encoded, so the only character we need to encode is ".

Change History (5)

comment:1 Changed 11 years ago by Jakub Ś

Status: new → confirmed

comment:2 Changed 11 years ago by Tade0

Owner: set to Tade0
Status: confirmed → assigned

comment:3 Changed 11 years ago by Tade0

Status: assigned → review

Shouldn't it rather be "​http://foo.com/bar%22bom"?

Pushed an implementation in which the quotation marks are urlencoded in the href to ​branch:t/13419.

comment:4 Changed 11 years ago by Olek Nowodziński

Status: review → review_passed

comment:5 Changed 11 years ago by Olek Nowodziński

Resolution: → fixed
Status: review_passed → closed

Merged ​git:e235295 into master.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy