Opened 12 years ago

Closed 11 years ago

Last modified 10 years ago

#1343 closed Bug (fixed)

Support for conditional compilation comments

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone:
Component: Project : CKPackager Version:
Keywords: Confirmed Review+ Cc:

Description

Conditional compilation comments must not be removed from the script while compressing. For example, the following code is completely removed today:

/*@cc_on
   @if (@_win32)
      document.write("OS is 32-bit. Browser is IE.");
   @else
      document.write("OS is NOT 32-bit. Browser is IE.");
   @end
@*/

This page has more information about the Conditional Compilation syntax.

Attachments (1)

1343.patch (673 bytes) - added by Frederico Caldeira Knabben 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by Wojciech Olchawa

Keywords: Confirmed added

Changed 11 years ago by Frederico Caldeira Knabben

Attachment: 1343.patch added

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

Keywords: Review? added

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newassigned

The proposed fix simply leaves conditional comments untouched.

comment:4 Changed 11 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:5 Changed 11 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [2237].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy