Opened 9 years ago

Last modified 9 years ago

#13472 closed Bug

[IE9-11] Dropped content is often inserted at selection position from before DnD — at Version 5

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.5.0
Component: General Version: 4.5.0
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

Reproducible on http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop when dropping from outside of the editors. First DnD works, but second no - content is inserted in the wrong place (previous selection position).

Change History (5)

comment:1 Changed 9 years ago by Piotrek Koszuliński

Description: modified (diff)
Milestone: CKEditor 4.5.1CKEditor 4.5.0
Summary: Unspecified Error thrown on IE9-11 in drag and drop sample in SDK[IE9-11] Dropped content often inserted at selection position from before DnD

comment:2 Changed 9 years ago by Piotrek Koszuliński

I raised priority of this ticket because this bug is very visible in the dnd sample in SDK.

comment:3 Changed 9 years ago by Piotrek Koszuliński

I pushed branch:t/13472. The fix is pretty simple - we stop using existing selection. Instead, we use the tricky mechanism that we created for IE8. From my tests I can see that it's much better. It does not work in some specific cases, as we know, but it does not fail when dropping from outside the editor. I'm worried only that we'll be now using it for all kinds of DnD, and the previous method worked better for internal DnD. So alternative patch may be to check data source.

Last edited 9 years ago by Piotrek Koszuliński (previous) (diff)

comment:4 Changed 9 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newreview

I pushed branch:t/13472b with what I think is a better fix. I noticed that focus is force in the editor and this cause automatic restoring of a previous selection. The fix was to remove that line, but then it turned out that external DnD does not work on IE8. So I moved the editor.focus() call to the method that we use on IE8.

comment:5 Changed 9 years ago by Piotrek Koszuliński

Description: modified (diff)
Summary: [IE9-11] Dropped content often inserted at selection position from before DnD[IE9-11] Dropped content is often inserted at selection position from before DnD
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy