Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13491 closed Bug (invalid)

Custom skins do not support notifications

Reported by: Steve James Owned by:
Priority: Normal Milestone:
Component: General Version: 4.5.0
Keywords: Cc:

Description

Please see the attached screen capture. I am seeing a transparent Notification for an image upload triggered by a drag and drop in IE11--I thought they were supposed to be colored? I am using a full-build instance of CKE 4.5.0 in a jQuery UI modal dialog. I have not tried loading an instance outside of a JQUI dialog. However, I did try to unload as many CKE plugins as I could (in case of a possible clash) but did not see any difference.

It looks like you do not yet have a UI : Notifications Component for bug tracking, so I filed this under UI : Dialogs

Attachments (1)

transparentnotification.JPG (186.8 KB) - added by Steve James 4 years ago.
Transparent Notification

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Steve James

Attachment: transparentnotification.JPG added

Transparent Notification

comment:1 Changed 4 years ago by Piotrek Koszuliński

Component: UI : DialogsGeneral
Keywords: Transparent Notifications removed
Resolution: invalid
Status: newclosed
Summary: Transparent Notifications?Custom skins do not support notifications

I'm afraid that your skin does not support notifications yet. The support must be added by the skin author.

As you can see here: http://sdk.ckeditor.com/samples/mediaembed.html by calling e.g. CKEDITOR.instances.editor1.showNotification( 'Foo bar' ); the notifications are fully styled.

We'll work on some article for skin authors how to upgrade their skins. But I'm sure it will take some time before skin authors make the changes.

For now, a workaround would be to load this file https://github.com/ckeditor/ckeditor-dev/blob/master/skins/moono/notification.css on your website manually.

comment:2 Changed 4 years ago by Steve James

For some reason, the workaround is not working for me. (good thought though)

In any case, is there any way to load moono 1st then load moonocolor so that there are fallbacks (from moono) for anything not defined in moonocolor?

comment:3 Changed 4 years ago by Piotrek Koszuliński

I've just checked the workaround and it worked for me. Maybe cache or paths or something?

In any case, is there any way to load moono 1st then load moonocolor so that there are fallbacks (from moono) for anything not defined in moonocolor?

That would end badly. Too many conflicting styles. But the workaround really must work - there's no reason why it wouldn't.

PS. We'll contact skin authors today to ask them to upgrade their skins. We've got a guide with instructions ready - https://github.com/ckeditor/ckeditor-docs/commit/488a7256d03b32e0ba5b6a1d0d95210a6089870f

comment:4 Changed 4 years ago by Steve James

Ok, I have this sorted out and the manual workaround is now working for me. The issue was that I thought your comment ...

For now, a workaround would be to load this file 
​https://github.com/ckeditor/ckeditor-dev/blob/master/skins/moono/notification.css 
on your website manually.

... meant that I should load notification.css into the skins/moonocolor folder and then ckeditor would load that. Needless to say, that did not work. I am now directly loading that stylesheet in my HTML head as I finally realized was the intent of your comment. I posted this follow-up so that it is clearer to others what they should do if while they are waiting for skins to get updated.

Last edited 4 years ago by Steve James (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy