Autoembed: Spontaneous re–embed of a link after undo and paste a non–embeddable content

[Olek Nowodziński]

1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/autoembed/manual/autoembed.
2. Copy an URL.
3. Paste the URL. The link becomes a widget.
4. Undo.
5. Place selection anywhere but not within a link.
6. Copy and paste anything which is not embeddable.

Expected: Pasted a new content.

Actual: Pasted a new content and re–embedded the link.

[Olek Nowodziński]

​branch:t/13532

[Piotr Jasiun]

You set embedCandidatePasted after if(transferType == INTERNAL) return; so:

1-5. Same.

6. Copy and paste anything intently in the editor.

Give the same result as before the fix.

Also ticket manual test would be useful witch steps to reproduce this ticket, for reviewer and the next release testers).

Additionally one line of description would be useful at the line where new variable is defined or used for the first time, now there is only ticket number at the last usage of it. It could also note that embedCandidatePasted should be set before any return.

[Olek Nowodziński]

Nice catch!

Replying to pjasiun:

You set embedCandidatePasted after if(transferType == INTERNAL) return; so:

1-5. Same.

6. Copy and paste anything intently in the editor.

Give the same result as before the fix.

Fixed in ​branch:t/13532b.

Also ticket manual test would be useful witch steps to reproduce this ticket, for reviewer and the next release testers).

It's hardly necessary if the issue is fully covered by AT. KISS.

Additionally one line of description would be useful at the line where new variable is defined or used for the first time, now there is only ticket number at the last usage of it. It could also note that embedCandidatePasted should be set before any return.

Done.

[Olek Nowodziński]

Pushed manual test to ​​branch:t/13532b.

[Piotr Jasiun]

So it is fixed.

​git:0d71fa2