Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#13730 closed Task (fixed)

Switch to the new logging mechanism

Reported by: Piotrek Koszuliński Owned by: Szymon Kupś
Priority: Normal Milestone: CKEditor 4.5.4
Component: General Version: 4.5.3
Keywords: Cc:

Description

Based on ​http://dev.ckeditor.com/ticket/13632#comment:19.

Change History (8)

comment:1 Changed 9 years ago by Piotrek Koszuliński

Status: new → confirmed

comment:2 Changed 9 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmed → review

comment:3 Changed 9 years ago by Piotrek Koszuliński

Status: review → review_failed

I pushed on commit to ​branch:t/13632-use – please check it.

I ran tests and there are two obvious reds: ​http://tests.ckeditor.dev:1030/tests/plugins/filetools/filetools and ​http://tests.ckeditor.dev:1030/tests/core/plugins/plugins

comment:4 Changed 9 years ago by Piotrek Koszuliński

I updated ​branch:t/13632-use with a correct link to the docs and I also pushed few commits to ​https://github.com/ckeditor/ckeditor-docs/tree/t/13632-use

comment:5 Changed 9 years ago by Szymon Kupś

Owner: changed from Piotrek Koszuliński to Szymon Kupś
Status: review_failed → assigned

comment:6 Changed 9 years ago by Szymon Kupś

Status: assigned → review

Fixed failed tests and updated ​branch:t/13632-use.

Last edited 9 years ago by Szymon Kupś (previous) (diff)

comment:7 Changed 9 years ago by Piotrek Koszuliński

Resolution: → fixed
Status: review → closed

Merged to master with ​git:6f07d5d and in the docs with ​https://github.com/ckeditor/ckeditor-docs/commit/7a7f40248d990ef567e1209122167d49d572a461

comment:8 Changed 9 years ago by Olek Nowodziński

Good job, guys! We should have implemented those years ago.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy