Opened 4 years ago

Last modified 3 years ago

#13791 confirmed New Feature

filebrowser plugin should fire fileUploadRequest

Reported by: ericpias Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc: andrey.fedoseev@…

Description

Steps to reproduce

I am following the documentation here: http://docs.ckeditor.com/#!/guide/dev_file_upload under "Editor Side Configuration" and trying to hook the fileUploadRequest event in order to modify the ajax post to my backend service. The fileUploadRequest event is just not firing for me. This is the problem. I do see the standard post received in my server code when I try this on my server, just no event fired in the browser side.

  1. Use the shared JSFiddle at: https://jsfiddle.net/ericpias/nrwaostw/
  2. In the CKEditor, select the image button and then the upload tab.
  3. Select a local image file.
  4. Make sure your browser's dev tools are open so you can see the console (or change the console.logs to alerts).
  5. Upload the file.
  6. The upload url won't work, but that is not important. The fileUploadRequest event never fires (nothing logged to the console).

Expected result

fileUploadRequest should fire in javascript.

Actual result

No fileUploadRequest event.

Notes

See: https://jsfiddle.net/ericpias/nrwaostw/

If I have misunderstood anything here, I appreciate your help in correcting me. Thanks.

Other details (browser, OS, CKEditor version, installed plugins)

Tried in Chrome and Firefox on Mac OSX. The jsFiddle example uses the full-all bundle from the CDN which should include the filetools plugin. Not clear to me if that is needed here or not.

Change History (4)

comment:1 Changed 4 years ago by Piotr Jasiun

Status: newconfirmed
Summary: Filetools plugin - fileUploadRequest is not firing/cannot be hooked.filebrowser plugin should fire fileUploadRequest
Type: BugNew Feature
Version: 4.5.3

Upload tab in the image dialog is provided by the filebrowser plugin. This is the plugin created to support integration with the file browsers long before upload plugins and fileUploadRequest event. This is why this plugin does not fire event introduced later. It means this bug is invalid.

But. I agree that the API should be consistent and all events related with upload and file handling should use fileUploadRequest. This is why filebrowser plugin should be updated and use the new API too.

So I changed this bug report to a valid feature request.

comment:2 Changed 4 years ago by Piotrek Koszuliński

Sounds like a new plugin is needed. I don't think the current one can be both – backwards compatible and support the new API. They are too much incompatible. So my proposal is to implement filebrowser2 :).

comment:3 Changed 4 years ago by Piotr Jasiun

+1 for a new plugin.

comment:4 Changed 3 years ago by Andrey Fedoseev

Cc: andrey.fedoseev@… added
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy