Opened 11 years ago

Closed 9 years ago

#13793 closed Task (fixed)

Embed plugin: use empty embed_provider by default

Reported by: Wiktor Walc Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.5.0
Keywords: Cc:

Description

The embed plugin has now //ckeditor.iframe.ly/api/oembed?url={url}&callback={callback} URL set by default as providerUrl.

As the default anonymized API end point has certain restrictions on its usage, it's better to make sure that each user using this plugin is aware of limitations (otherwise there is a risk that suddenly on a production website this service will stop working_. This effect can be only reached by removing the predefined end point n the plugin configuration and having users reading the documentation in order to specify it manually.

The documentation should list //ckeditor.iframe.ly/api/oembed?url={url}&callback={callback} as a "ready to use" option, but it should also recommend setting up an account on Iframely to better track the API usage (even in the free "Developer" tier plan).

Change History (12)

comment:1 Changed 11 years ago by Jakub Ś

Status: new → confirmed

comment:2 Changed 10 years ago by Tade0

Owner: set to Tade0
Status: confirmed → assigned

comment:3 Changed 10 years ago by Tade0

Status: assigned → review

Updated the default and the docs accordingly, changes pushed to ​branch:t/13793.

Relevant pull request in the docs repo: ​https://github.com/ckeditor/ckeditor-docs/pull/71

comment:4 Changed 10 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.0 → CKEditor 4.6.1

comment:5 Changed 10 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.1 → CKEditor 4.6.2
Status: review → review_failed

Editor should report an error explaining the reason of the problem in case of missing embed_provider. Use ​`error` method for this purpose.

Last edited 10 years ago by Marek Lewandowski (previous) (diff)

comment:6 Changed 10 years ago by Tade0

Status: review_failed → review

Added this. Error explained in the associated docs pull request.

comment:7 Changed 10 years ago by Marek Lewandowski

Pushed a couple of changes to t/13793 branch, now it looks pretty much fine, but the related docs pull request needs to be adjusted.

comment:8 Changed 10 years ago by Marek Lewandowski

Status: review → review_failed

comment:9 Changed 10 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.2 → CKEditor 4.7.0

Moved to major milestone, as we don't want to make such a breaking change in a minor release.

comment:10 Changed 10 years ago by Tade0

Status: review_failed → review

Updated the docs as requested.

comment:11 Changed 9 years ago by kkrzton

Rebased on current major, corrected docs typo and added unit tests. Created PR ​https://github.com/ckeditor/ckeditor-dev/pull/342.

comment:12 Changed 9 years ago by Marek Lewandowski

Resolution: → fixed
Status: review → closed
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy