Opened 4 years ago

Last modified 2 years ago

#13842 assigned Bug

List Plugin adds extra <br> when making styled text a list

Reported by: scott schmitz Owned by: Tomasz Jakut
Priority: Must have (possibly next milestone) Milestone:
Component: Core : Lists Version: 4.5.0
Keywords: Cc:

Description (last modified by Marek Lewandowski)

Steps to reproduce

  1. you can use the demo - type in 5 lines of text. Break the lines with shift+return
  1. Select that text and some more and make all that text bold
  1. Select 3 of those lines and click on the list control

Expected result

You will see that extra return characters have been added to the list items

Actual result

The list should be clean with no extra CR's.

Other details (browser, OS, CKEditor version, installed plugins)

This test was run on 4.5.4 This bug was NOT present in version 3.6.6

Related Issues

Attachments (5)

margins.png (107.3 KB) - added by Jakub Ś 4 years ago.
shot_1.png (83.6 KB) - added by scott schmitz 4 years ago.
shot 1
shot_2.png (87.0 KB) - added by scott schmitz 4 years ago.
shot 2
shot_3.png (66.6 KB) - added by scott schmitz 4 years ago.
shot 3
shot_4.png (63.3 KB) - added by scott schmitz 4 years ago.
shot 4

Download all attachments as: .zip

Change History (23)

comment:1 Changed 4 years ago by scott schmitz

I tested this on Firefox and on Chrome and got the same result

Changed 4 years ago by Jakub Ś

Attachment: margins.png added

comment:3 Changed 4 years ago by scott schmitz

OK, I'll explain with some screen shots.

  1. I type in several lines and when I type return I hold down the shift key. See screen shot 1
  2. I select all of the text in the field and make it bold - see screen shot 2.
  3. I select the text that is one, two, three and click on the unordered list control - see screen shot 3

As you can see it does not look right. I have included shot 4 screen shot which shows how things should look.

thanks,

Scott.

Changed 4 years ago by scott schmitz

Attachment: shot_1.png added

shot 1

Changed 4 years ago by scott schmitz

Attachment: shot_2.png added

shot 2

Changed 4 years ago by scott schmitz

Attachment: shot_3.png added

shot 3

Changed 4 years ago by scott schmitz

Attachment: shot_4.png added

shot 4

comment:4 in reply to:  2 Changed 4 years ago by scott schmitz

Replying to j.swiderski:

Please see attached image.

The only extra "return characters" I have found were list margins added by browser. These margins can be overwritten by defining list rules in contents css e.g. ul {margin:0;}.

I'm closing this issue as invalid. @SSchmitz99 if this is not what you have meant and there are some new lines, please provides exact steps to reproduce this issue and provide a screen shot.

OK, I'll explain with some screen shots.

I type in several lines and when I type return I hold down the shift key. See screen shot 1 I select all of the text in the field and make it bold - see screen shot 2. I select the text that is one, two, three and click on the unordered list control - see screen shot 3 As you can see it does not look right. I have included shot 4 screen shot which shows how things should look.

thanks,

Scott.

comment:5 Changed 4 years ago by Jakub Ś

Status: newconfirmed
Version: 4.5.44.5.0

I have removed my previous comment because I have missed the "bold the text" part.

@SSchmitz99 thank you for further explanations - issue is valid, reproducible in all browsers from CKEditor 4.5.0

comment:6 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.5
Priority: NormalHigh

comment:7 Changed 3 years ago by Tomasz Jakut

Owner: set to Tomasz Jakut
Status: confirmedassigned

comment:8 Changed 3 years ago by Tomasz Jakut

The problem is caused by changes from 1f2496, most probably the line #395 from core/dom/range.js (not passing toStart as a second argument of node.append method).

comment:9 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.5CKEditor 4.5.6

comment:10 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6CKEditor 4.5.7

comment:11 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7CKEditor 4.5.8

comment:12 Changed 3 years ago by Marek Lewandowski

Description: modified (diff)

comment:13 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

comment:14 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.10

comment:15 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.10CKEditor 4.5.11

Moving tickets to the next milestone.

comment:16 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.11CKEditor 4.6.1

comment:17 Changed 2 years ago by Marek Lewandowski

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

comment:18 Changed 2 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.1CKEditor 4.6.2

comment:19 Changed 2 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.2

As much as we need it, we won't be able to contain it within upcoming release. Moving to our hi prio todolist.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy