Opened 4 years ago

Closed 4 years ago

#13929 closed Bug (fixed)

[IE11 CM] Polyfill for classList throws error in manual test.

Reported by: Tomasz Jakut Owned by: Tomasz Jakut
Priority: Normal Milestone: CKEditor 4.5.10
Component: General Version: 4.5.5
Keywords: Cc:

Description

Steps to reproduce

  1. Open http://tests.ckeditor.dev:10455/tests/tickets/13867/1.

Expected result

There aren't any errors logged.

Actual result

SCRIPT5009: 'Element' is undefined is logged.

Other details (browser, OS, CKEditor version, installed plugins)

Internet Explorer 11 with Compatibility View on.

Change History (8)

comment:1 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6

comment:2 Changed 4 years ago by Tomasz Jakut

Owner: set to Tomasz Jakut
Status: newassigned

comment:3 Changed 4 years ago by Tomasz Jakut

Status: assignedreview

There is no sensible way to polyfill Element.prototype.classList in IE < 8 as it doesn't even expose Element. So I changed the code to stub classList only if window.Element is available. Pushed branch:t/13929.

comment:4 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6CKEditor 4.5.7

comment:5 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7CKEditor 4.5.8

comment:6 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

comment:7 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.10

comment:8 Changed 4 years ago by Tade0

Resolution: fixed
Status: reviewclosed

Fix works fine. I did a slight modification to the tests.

My reasoning behind this: The person reading the tests is only interested in the direct reason as to why the tests are ignored (either browser supports classList or classListStub doesn't exist for some reason), not the indirect reasons(which may be potentially multiple and complex).

Fixed with git:f8b0a809e0f8b87fb2b994f4a3105556a18072a3.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy