Opened 9 years ago
Closed 9 years ago
#13929 closed Bug (fixed)
[IE11 CM] Polyfill for classList throws error in manual test.
| Reported by: | Tomasz Jakut | Owned by: | Tomasz Jakut |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.10 |
| Component: | General | Version: | 4.5.5 |
| Keywords: | Cc: |
Description
Steps to reproduce
Expected result
There aren't any errors logged.
Actual result
SCRIPT5009: 'Element' is undefined is logged.
Other details (browser, OS, CKEditor version, installed plugins)
Internet Explorer 11 with Compatibility View on.
Change History (8)
comment:1 Changed 9 years ago by
| Milestone: | → CKEditor 4.5.6 |
|---|
comment:2 Changed 9 years ago by
| Owner: | set to Tomasz Jakut |
|---|---|
| Status: | new → assigned |
comment:3 Changed 9 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 9 years ago by
| Milestone: | CKEditor 4.5.6 → CKEditor 4.5.7 |
|---|
comment:5 Changed 9 years ago by
| Milestone: | CKEditor 4.5.7 → CKEditor 4.5.8 |
|---|
comment:6 Changed 9 years ago by
| Milestone: | CKEditor 4.5.8 → CKEditor 4.5.9 |
|---|
comment:7 Changed 9 years ago by
| Milestone: | CKEditor 4.5.9 → CKEditor 4.5.10 |
|---|
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fix works fine. I did a slight modification to the tests.
My reasoning behind this: The person reading the tests is only interested in the direct reason as to why the tests are ignored (either browser supports classList or classListStub doesn't exist for some reason), not the indirect reasons(which may be potentially multiple and complex).
Fixed with git:f8b0a809e0f8b87fb2b994f4a3105556a18072a3.
Note: See
TracTickets for help on using
tickets.
There is no sensible way to polyfill
Element.prototype.classListin IE < 8 as it doesn't even exposeElement. So I changed the code to stubclassListonly ifwindow.Elementis available. Pushed branch:t/13929.