FCKToolbarSet Detached Toolbar Flicker

[Scott McNaught]

When the toolbar is detached, and using the IFRAME mode, the toolbar can flicker on load as as it adjusts its size. There is a browser hack which adjusts the frame height using setTimeout() with a delay of 1 second,

I beleive the way that this is implemented could be improved.

The code is: window.onload = function () {adjust(); window.setTimeout( adjust, 1000 ); }

• The initial call to adjust() is not needed as when it adjusts, on most browsers it adjusts to the wrong size anyway (causing flicker)
• There does not appear to be a need for the 1000ms delay (calling it via setTimeout ensures anyway that the DOM has been fully constructed before calling the function)

I suggest that this be changed to simply:

window.setTimeout( adjust, 0 );

I have attached a patch.

[Alfonso Martínez de Lizarrondo]

That code is present to fix #272

[Scott McNaught]

It seems like calling the adjust method via setTimeout() fixes #272 (from my testing).

My suggestion is to remove the initial adjust() which adjusts to the wrong position, and to remove the 1 second delay.

[Alfonso Martínez de Lizarrondo]

I've tested right now (sorry for the delay) and it seems that you are right. I think that I already did test initially with a 0 delay, but I might be wrong.

Commited [1070], thank you.

[Scott McNaught]

Thanks a lot.

Scott