Opened 3 years ago

Closed 2 years ago

#14275 closed New Feature (fixed)

Proper error reporting in scriptloader for all browsers.

Reported by: kkrzton Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.5.10
Component: General Version:
Keywords: Cc: Marek Lewandowski

Description

While working on #13943 there was a need to check if config scripts were loaded successfully. It is partially supported by scriptloader but not for all browsers (IE < 11, Safari, Opera - probably before migrating to Webkit). It is not really supported by those browsers in a proper way but still it may be needed in the future so probably should be done.

if ( CKEDITOR.env.ie && CKEDITOR.env.version < 11 ) {
    // FIXME: For IE, we are not able to return false on error (like 404).
    script.$.onreadystatechange = function() {
        ...
} else {
    ...

    // FIXME: Opera and Safari will not fire onerror.
    script.$.onerror = function() {
        ...

part of scriptloader.js loadScript function with planned fixes

Change History (8)

comment:1 Changed 3 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7

comment:3 Changed 3 years ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:4 Changed 3 years ago by kkrzton

Status: assignedreview

Changes in t/14275.

There is no any nice & clean solution for IE8 so it works as before in IE8.

comment:5 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7CKEditor 4.5.8

comment:6 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

comment:7 Changed 2 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.10

comment:8 Changed 2 years ago by Tade0

Resolution: fixed
Status: reviewclosed

I had to correct the condition under which one test is ignored, but overall I'm seeing that this fix brings an improvement.

Fixed with git:d7e067154ed0407a355c77266e6f2f93ca81bf93.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy