Opened 8 years ago
Closed 8 years ago
#14296 closed Bug (fixed)
Failing filetools test after merge
| Reported by: | Marek Lewandowski | Owned by: | kkrzton |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.6.0 |
| Component: | General | Version: | 4.6.0 |
| Keywords: | Cc: |
Description
After mergin master to major branch one test fails as it was not aware of changes introduced in 4.6.0.
The fialing test is test CSRF token appending merged with git commit 5305f294d9e583ca0f9731c6051782b87bb3757c.
In order to provide backward compatibility filetools/plugin.js:45 line should init .requestData property as an empty object if not given.
In turn we will no longer need a default value initialization in filetools/plugin.js:543 line so it can be dropped, and function argument can be used directly in fire() call.
Change History (4)
comment:1 Changed 8 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 8 years ago by
| Owner: | set to kkrzton |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 8 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed with git:b7fb502, merged to major.
Note: See
TracTickets for help on using
tickets.
Changes (as suggested in description) in t/14296.