We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Ticket
Next Ticket →

Opened 10 years ago

Last modified 10 years ago

#14532 confirmed Bug

Inconsistent API of dialog.openDialog

Reported by:	Godefroid Chapelle	Owned by:
Priority:	Normal	Milestone:
Component:	General	Version:	4.5.7
Keywords:		Cc:

Description

In case of asynchronous loading of the dialog script with scriptLoader, dialog variable is null. In the other case, when the dialog had already been loaded, dialog variable points to the actual dialog.

As this API cannot be consistent because of asynchronous load, I'd suggest returning nothing. IOW remove the line with return

Also, the documentation is wrong.

See https://github.com/ckeditor/ckeditor-dev/commit/ebf122f4ab28dbae57fb6176d2e1d281486ae834#commitcomment-16761658

Change History (1)

comment:1 Changed 10 years ago by Marek Lewandowski

Status:	new → confirmed

Note: See TracTickets for help on using tickets.

Download in other formats: