Opened 3 years ago

Last modified 3 years ago

#14532 confirmed Bug

Inconsistent API of dialog.openDialog

Reported by: Godefroid Chapelle Owned by:
Priority: Normal Milestone:
Component: General Version: 4.5.7
Keywords: Cc:

Description

In case of asynchronous loading of the dialog script with scriptLoader, dialog variable is null. In the other case, when the dialog had already been loaded, dialog variable points to the actual dialog.

As this API cannot be consistent because of asynchronous load, I'd suggest returning nothing. IOW remove the line with return

Also, the documentation is wrong.

See https://github.com/ckeditor/ckeditor-dev/commit/ebf122f4ab28dbae57fb6176d2e1d281486ae834#commitcomment-16761658

Change History (1)

comment:1 Changed 3 years ago by Marek Lewandowski

Status: newconfirmed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy