Opened 4 years ago

Last modified 4 years ago

#14550 review Bug

Direct path to handle.png in widget plugin

Reported by: Karen Ananiev Owned by: Tade0
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

There is the direct path https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/widget/plugin.js#L3132 to the image file instead of CKEDITOR.getUrl and that causes the issue when custom CKEDITOR_GETURL function is used.

Change History (5)

comment:1 Changed 4 years ago by Jakub Ś

Status: newpending
Version: 4.5.7

and that causes the issue when custom CKEDITOR_GETURL function is used.

Ticket makes a lot of sense but before confirming it, could you perhaps tell me what issue where you getting with direct URL to handle and custom getUrl function?

comment:2 Changed 4 years ago by Karen Ananiev

Of course. We use CDN and add site id and some fingerprint to the static files. So the path looks like https://cdn.hostname/path/file.ext?_=fingerprint:site_id and CDN returns 404 for the requests without that query param.

comment:3 Changed 4 years ago by Jakub Ś

Status: pendingconfirmed

Having getURL in that place could definitely solve such problems.

comment:4 Changed 4 years ago by Marek Lewandowski

Correct, this could be improved. Luckily there's an easy workaround for this issue, so if anyone face this problem, you could override it in your config.contentsCss stylesheet:

.cke_widget_drag_handler_container {
	background-image: url(https://dev.null/my-custom-image.png) !important;
}
Last edited 4 years ago by Marek Lewandowski (previous) (diff)

comment:5 Changed 4 years ago by Tade0

Owner: set to Tade0
Status: confirmedreview

Fixed.

Changes pushed to branch:t/14550.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy