Opened 9 years ago
Closed 9 years ago
#14559 closed Bug (fixed)
Cannot confirm table dialog in quirks mode when headers set - regression.
| Reported by: | Tade0 | Owned by: | kkrzton |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.8 |
| Component: | General | Version: | 4.5.8 |
| Keywords: | Cc: |
Description (last modified by )
Steps to reproduce
- Open the table dialog.
- Set headers to "both".
- Click Ok.
Expected result
Dialog closes, table is inserted.
Actual result
Dialog stays, "error on page", and nothing else happens.
Other details (browser, OS, CKEditor version, installed plugins)
IE8, quirks mode.
Bisection shows that the commit that causes this regression has hash: e33503b7d63710a4c7d4ca8ef2bc2e41c3d9116f
Change History (7)
comment:1 Changed 9 years ago by
| Milestone: | → CKEditor 4.5.8 |
|---|
comment:2 Changed 9 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 9 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 9 years ago by
| Owner: | set to kkrzton |
|---|---|
| Status: | confirmed → assigned |
comment:5 Changed 9 years ago by
comment:6 Changed 9 years ago by
| Status: | assigned → review |
|---|
Changes in t/14559.
Used getElementsByTag( 'thead' ).getItem( 0 ) instead of findOne( 'thead' ) to support quirks mode.
comment:7 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed with git:c1fc9a9.
Note: See
TracTickets for help on using
tickets.
cc