Opened 3 years ago

Closed 3 years ago

#14559 closed Bug (fixed)

Cannot confirm table dialog in quirks mode when headers set - regression.

Reported by: Tade0 Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.5.8
Component: General Version: 4.5.8
Keywords: Cc:

Description (last modified by Tade0)

Steps to reproduce

  1. Open the table dialog.
  2. Set headers to "both".
  3. Click Ok.

Expected result

Dialog closes, table is inserted.

Actual result

Dialog stays, "error on page", and nothing else happens.

Other details (browser, OS, CKEditor version, installed plugins)

IE8, quirks mode.

Bisection shows that the commit that causes this regression has hash: e33503b7d63710a4c7d4ca8ef2bc2e41c3d9116f

Change History (7)

comment:1 Changed 3 years ago by Tade0

Milestone: CKEditor 4.5.8

comment:2 Changed 3 years ago by Marek Lewandowski

Status: newconfirmed

comment:3 Changed 3 years ago by Tade0

Description: modified (diff)

comment:4 Changed 3 years ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:5 Changed 3 years ago by Marek Lewandowski

cc

comment:6 Changed 3 years ago by kkrzton

Status: assignedreview

Changes in t/14559.

Used getElementsByTag( 'thead' ).getItem( 0 ) instead of findOne( 'thead' ) to support quirks mode.

comment:7 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Fixed with git:c1fc9a9.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy