Opened 9 years ago
Closed 9 years ago
#14573 closed Bug (fixed)
Multiple editors, drag handler icon and divarea, missing CSS
Reported by: | AlexW | Owned by: | kkrzton |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.9 |
Component: | UI : Widgets | Version: | 4.3 |
Keywords: | Cc: |
Description
An example can be seen here, https://jsfiddle.net/ew490f12/1/ Hover over the widget in the second editor.
If you have two editors using divarea
with the second using the enhanced image plugin the drag handle seems to be missing CSS so the image is full width and repeated.
Change History (6)
comment:1 Changed 9 years ago by
Status: | new → confirmed |
---|---|
Version: | 4.5.8 → 4.3 |
comment:2 Changed 9 years ago by
Milestone: | → CKEditor 4.5.9 |
---|
comment:3 Changed 9 years ago by
Owner: | set to kkrzton |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 9 years ago by
Status: | assigned → review |
---|
Changes in t/14573.
The issue was caused by the fact that CKEditor adds inline stylesheet to the DOM and the code does not overwrite it if styles changes (many instances and one adds some styles after the stylesheet were appended to the DOM already - the exact case which causes above issue). The solution is to check if styles have changed and update already appended stylesheet accordingly.
comment:5 Changed 9 years ago by
Status: | review → review_passed |
---|
The fix works fine, the tests are passing, I believe this solution should do.
Side note: I see that you fixed that code style problem that keeps popping up recently. I'm having some mixed feelings about the style of the fix, but then again it's doing much less damage readability-wise than my solution for the same problem.
Fixed with git:d8486d54ebaeffaa940a28f1a8b972047c345bc3, merged to master.
comment:6 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Problem can be reproduced from at least CKEditor 4.3.