Opened 3 years ago

Closed 3 years ago

#14605 closed Bug (fixed)

Test for pagebreak fails in Chrome

Reported by: Tomasz Jakut Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.5.9
Component: General Version: 4.5.9
Keywords: Cc:

Change History (7)

comment:1 Changed 3 years ago by Tomasz Jakut

Status: newconfirmed

comment:2 Changed 3 years ago by Tade0

Apparently current Chrome uses the newer property break-after instead of page-break-after.

I'll modify the test so that it takes this change into account.

comment:3 Changed 3 years ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:4 Changed 3 years ago by Tade0

Status: assignedreview

More specifically currently in Chrome, when the style page-break-after: always is applied, it's represented as such in the DOM and dev tools, *but*, when getting the DOM element style in JS, the style object properties are as follows:

pageBreakAfter: ""

breakAfter: "page"

Changes pushed to branch:t/14605.

comment:5 Changed 3 years ago by Tade0

Also: Tested on Chrome, Firefox, IE11 and Edge.

comment:6 Changed 3 years ago by kkrzton

Status: reviewreview_passed

This http://dev.ckeditor.com/ticket/14605#comment:4 is what exactly happens. I only added ticket reference in the fixed test. Looks good, R+.

comment:7 Changed 3 years ago by kkrzton

Resolution: fixed
Status: review_passedclosed

Fixed with git:669f6f555d (merged to master).

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy