Changes between Initial Version and Version 3 of Ticket #14620
- Timestamp:
- May 4, 2016, 11:31:59 AM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #14620
-
Property
Status
changed from
newtoassigned - Property Owner set to kkrzton
-
Property
Status
changed from
-
Ticket #14620 – Description
initial v3 1 1 This issue comes from https://www.drupal.org/node/2239419. 2 2 3 What happens there is that D8 is overriding height attribute for `html` element, [https://github.com/drupal/drupal/blob/bf28e3d006fda29b0a67f2e6bb7ed1f218ab43be/core/themes/bartik/css/base/elements.css#L7 by setting it to 100%]. Thisbreaks the autogrow plugin.3 What happens there is that D8 is overriding [https://github.com/drupal/drupal/blob/bf28e3d006fda29b0a67f2e6bb7ed1f218ab43be/core/themes/bartik/css/base/elements.css#L10 min-height attribute for body element] which with connection to [https://github.com/drupal/drupal/blob/bf28e3d006fda29b0a67f2e6bb7ed1f218ab43be/core/themes/bartik/css/base/elements.css#L7 height: 100%] for `html` breaks the autogrow plugin. 4 4 5 To prevent that we could set html's element `height` to `auto` in [https://github.com/ckeditor/ckeditor-dev/blob/bb8028d63bd2e6602ce372f7c6dbbfcf734fa0ef/plugins/autogrow/plugin.js#L30 initIframeAutogrow] and it should work just fine.5 To prevent that we could set `body`'s element `min-height` (and probably `height`) to `auto` in [https://github.com/ckeditor/ckeditor-dev/blob/bb8028d63bd2e6602ce372f7c6dbbfcf734fa0ef/plugins/autogrow/plugin.js#L30 initIframeAutogrow] and it should work just fine. Note that it cannot be solved by setting `html`'s element `height` to `auto` due to [https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/wysiwygarea/plugin.js#L604 gecko wyswigarea plugin fix]. 6 6 7 7 You'll find some useful findings here https://www.drupal.org/node/2239419#comment-10906692.
