Opened 9 years ago
Closed 9 years ago
#14672 closed Bug (fixed)
Balloonpanel not blurred on close
Reported by: | Tade0 | Owned by: | Tade0 |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.6.0 |
Component: | General | Version: | |
Keywords: | Cc: |
Description ¶
Steps to reproduce ¶
- Open http://tests.ckeditor.dev:1030/tests/plugins/balloonpanel/manual/balloonpanel.
- Double click any of the red fragments to select a word and open a balloon panel.
- Close the balloon panel.
Expected result ¶
Editor gains focus.
Actual result ¶
Editor does not gain focus.
Other details (browser, OS, CKEditor version, installed plugins) ¶
Chrome, Ubuntu 14.04

Change History (5)
comment:1 Changed 9 years ago by
Owner: | set to Tade0 |
---|---|
Status: | new → review |
comment:2 Changed 9 years ago by
Status: | review → review_failed |
---|
While the fix looks and works well, we do not have any tests for this specific case. There is only general manual test (http://tests.ckeditor.dev:1030/tests/plugins/balloonpanel/manual/balloonpanel). While this case is pretty simple we can:
- add another manual test specific for this case
- modify existing test by adding description what is expected result of some actions, e.g.
When closing ballonpanel editor should gain/restore focus.
comment:3 Changed 9 years ago by
Status: | review_failed → review |
---|
Added manual test for this specific case.
Changes pushed to branch:t/14672.
comment:4 Changed 9 years ago by
Status: | review → review_passed |
---|
Looks good, corrected only one typo in a manual test, R+.
comment:5 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Merged to major
with 10377f5.

Added a blur method call where it should be according to the comment in the code.
Changes pushed to branch:t/14672.