convertToPx function in RTL mode

[Irina]

In convertToPx function style attribute is always set to left even when editor is in RTL mode, e.g.

calculator = CKEDITOR.dom.element.createFromHtml( '<div style="position:absolute;left:-9999px;' +
                        'top:-9999px;margin:0px;padding:0px;border:0px;"' +
                        '></div>', CKEDITOR.document );

Should this be replaced with 'right' for RTL mode?

[Jakub Ś]

Goal of this function is to convert non-px to px but it makes sense to move it to the right in RTL mode so as to not show it by accident.

Maybe the values should be made bigger. The 9999px may be too small these days.

[Tade0]

Interestingly this function had no test coverage, so I added them.

As mentioned earlier in principle this shouldn't be dependant on LTR-RTL, so I simply added a "1" before each value.

Changes pushed to ​branch:t/14721.

[Marek Lewandowski]

While reviewing I saw that it should be pretty much language direction-independent. This element is inserted directly into the body and is positioned absolutely so moving it outside left border of body will take effect on both ltr and rtl languages.

@irina can I ask you to provide a case where it fails?