The enhanced image caption does not support the link target attribute.

[ahmad]

Steps to reproduce

1.Click on the enhanced image (image2) in the editor and add a url to the image and select the captioned image checkbox.

2. select the caption text and click the link icon in the editor.
3. in the link dialog you will notice that the target tab is disabled

Expected result

the expected result should be that the caption should also support the link target attribute.

you can reproduce this on the demo page.

[Jakub Ś]

This is not a bug. This is a feature.

It is enough to add target attribute to caption's ACF ​https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/image2/plugin.js#L289

[ahmad]

I added like this

allowedContent: 'br em strong sub sup u s target; a[!href]; a[target]'
allowedContent: 'br em strong sub sup u s target; a[!href]'
allowedContent: 'br em strong sub sup u s; a[!href]; a[!target]'

but none of it worked. Can you please guide me how to add the target attribute?

[Jakub Ś]

Try this (don't forget to clear browser's cache (this is not Ctrl+F5)):

allowedContent: 'br em strong sub sup u s; a[!href,target]'

and please read something about ACF:
​http://docs.ckeditor.com/#!/guide/dev_acf
​http://docs.ckeditor.com/#!/guide/dev_advanced_content_filter
​http://docs.ckeditor.com/#!/guide/dev_disallowed_content
​http://docs.ckeditor.com/#!/api/CKEDITOR.filter-method-addTransformations
​http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-allowedContent
​http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-extraAllowedContent

[Tade0]

Changed the filtering so that now link targets are allowed in the caption.

Changes pushed to ​branch:t/14747.

[kkrzton]

The fix is fine.

Unfortunately, all IE browsers (IE8-IE11, Edge) has different attributes order and the added test fails (see attached screenshot).

[Marek Lewandowski]

Just to chime in, assert.isInnerHtmlMatching will be your friend.

[Tade0]

Corrected the error, rebased with master, changes pushed to ​branch:t/14747.

[kkrzton]

LGTM, R+.

[kkrzton]

Merged to master with ​2f98a20.