Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#14763 closed Task (fixed)

AC and Balloonpanel plugins moono-lisa skin adjustments.

Reported by: kkrzton Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.6.0
Component: UI : Skins Version:
Keywords: Cc:

Description

Related to t/14569.

The balloonpanel and a11ychecker plugins have separate stylesheets which should be adjusted to the new moono-lisa skin.

Change History (10)

comment:1 Changed 3 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 3 years ago by Olek Nowodziński

cc

comment:3 Changed 3 years ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:4 Changed 3 years ago by kkrzton

Status: assignedpending

The AC skin adjustments are currently reviewed by the CKSource team (which probably means some polishing will be needed).

However, I already created the branches with adjustments: balloonpanel and a11ychecker (and also AC overlay PoC branch).

comment:5 Changed 2 years ago by kkrzton

Status: pendingreview

Two branches were created for this task:

  • One in ckeditor-dev repo with changes in balloonpanel (while it became a core plugin in the latest major) - t/14763.
  • One in ckeditor-plugin-a11ychecker repo with changes in AC styles - t/14763.

The branch in ckeditor-dev adds balloonpanel CSS files for moono-lisa skin. One important thing to notice - it is based on t/14569. Without changes from t/14569 the balloonpanel could not be properly tested (visually).

The branch in ckeditor-plugin-a11ychecker, apart from new skin files, introduces some changes in less workflow. Previously it was not prepared to handle (build and use) more than one skin. These changes were introduced in 1349924 commit.

comment:6 Changed 2 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Fixed with git:570f5aabd2 (merged to major).

I've also added a manual test for old moono skin.

comment:7 Changed 2 years ago by kkrzton

@m.lewandowski the link to the merge commit does not work and in fact I don't see this merge on major branch. Are you sure you properly pushed this merge?

By the way, this ticket is also about branch t/14763 in ckeditor-plugin-a11ychecker so before closing it, this branch should be also reviewed and merged.

comment:8 Changed 2 years ago by Marek Lewandowski

Resolution: fixed
Status: closedreopened

My bad, the branch wasn't pushed. As for closing ticket - all right, let's close it together with AC tickets.

comment:9 Changed 2 years ago by Marek Lewandowski

Resolution: fixed
Status: reopenedclosed

AC skin improvements were merged with ckeditor-plugin-a11ychecker#228 issue.

comment:10 Changed 2 years ago by kkrzton

Merge commits:

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy