Opened 8 years ago
Closed 8 years ago
#14894 closed Bug (fixed)
Editor scrolls to top when focused or when dialog is opened.
Reported by: | Jakub Ś | Owned by: | Tade0 |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.7.0 |
Component: | General | Version: | |
Keywords: | Chrome | Cc: |
Description
Steps to reproduce
These are two issues in fact. First one concerns opening dialog when editor is not focused and second one is the continuation of #14659.
Test Case 1
- http://dev.ckeditor.com/ticket/14659#comment:6. Test case from that comment is still reproducible (starting from 4.0.0).
Test Case 2
- Open sample page - replacebycode.html or divarea.html
- Scroll editor a little bit without focusing it
- Open Link dialog
This test case can be reproduced in both classic (starting from 4.4.6) and divarea editor (starting from 4.0.0)
Expected result
Editor should not scroll.
Actual result
In both cases editor will be scrolled to top.
Other details (browser, OS, CKEditor version, installed plugins)
Problem can be reproduced in Chrome browser only
Change History (8)
comment:1 Changed 8 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 8 years ago by
Milestone: | CKEditor 4.6.1 → CKEditor 4.6.2 |
---|
comment:3 Changed 8 years ago by
Milestone: | CKEditor 4.6.2 → CKEditor 4.7.0 |
---|
comment:4 Changed 8 years ago by
Owner: | set to Tade0 |
---|---|
Status: | confirmed → assigned |
comment:5 Changed 8 years ago by
Status: | assigned → review |
---|
Here's an admittedly blunt, yet working solution.
Reasoning: we have no control over what exaclty happens when a native method is called, so we need to work around it.
Changes pushed to branch:t/14894.
comment:6 follow-up: 7 Changed 8 years ago by
Status: | review → review_failed |
---|
Fix is working fine, but it lacks unit test. It shouldn't be too hard to create. I'm also not sure if it wouldn't be better to apply this fix only to Chrome.
comment:7 Changed 8 years ago by
Status: | review_failed → review |
---|
Replying to t.jakut:
I'm also not sure if it wouldn't be better to apply this fix only to Chrome.
Yeah, I probably should.
Added unit test, changes pushed to branch:t/14894.
comment:8 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
LGTM, I've just polished it a bit and merged to major with git:af78e85.
Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.