#1552 closed Bug (fixed)
Implement Safari and Opera detection
| Reported by: | Frederico Caldeira Knabben | Owned by: | Thilo Schwarz |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | FCKeditor.Java 2.4 |
| Component: | Server : Java | Version: | |
| Keywords: | Cc: |
Description
The Java implementation is not detecting Safari and Opera, for compatibility with FCKeditor 2.5.
The PHP implementation may be used as the base for it.
Attachments (2)
Change History (13)
comment:1 Changed 17 years ago by
| Priority: | Normal → High |
|---|
comment:2 Changed 17 years ago by
Changed 17 years ago by
| Attachment: | FCKeditor.java added |
|---|
comment:4 follow-up: 5 Changed 17 years ago by
I'm trying to create a SVN patch with your changes, but your file seems completely different. It seems that line breaks have been doubled. Also, JavaDoc comments have been changed (for worst, I mean). It is quite difficult to isolate your changes in a patch.
Do you think you are able to provide a SVN patch file, or even a diff file with the changes related to this ticket exclusively?
comment:6 Changed 17 years ago by
Replying to axmu:
How do I create a SVN patch file?
I've just create the SVN Basics page to give some information on this.
In that page, you will find references to the "FCKeditor trunk" URL. In your case, you need instead the "FCKeditor.Java trunk" URL, which points to:
http://svn.fckeditor.net/FCKeditor.Java/trunk
I hope it will help you.
comment:7 Changed 17 years ago by
| Owner: | set to Thilo Schwarz |
|---|
comment:8 Changed 17 years ago by
| Status: | new → assigned |
|---|
comment:9 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Stupid quustion: Where
comment:10 Changed 17 years ago by
We also need the Safari support so I've taken axmu's code and tried to redo the changes based on the trunk. I've changed it slighty as I found the code (as I read it) didn't quite work - the version of Safari I have has "gecko" in the user agent string so I have swapped around the "gecko" and the "applewebkit" tests. I have Safari on the Mac, v3.0.4 (523.12.2)
I've created a patch file and attached it as 1552.patch. I've never done a SVN patch before, so I hope it has come out in the right format.
comment:11 Changed 17 years ago by
The patch is ok fmalikoff. The code seems also to be correct.
The only thing that I don't like much in that implementation is that the retrieveBrowserVersion does the "if (userAgent.indexOf("something")..." again, exactly like it was done in the isCompatible. I think this repetition could be avoided, even passing the browser name as a parameter to retrieveBrowserVersion.
In any case, I would point all you to the PHP implementation of it, which you could use as a base: source:FCKeditor/trunk/fckeditor.php
#1708 has been marked as DUP.