Opened 12 years ago

Closed 12 years ago

#1607 closed Task (fixed)

Remove FCKConfig.GeckoUseSPAN

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone: FCKeditor 2.6
Component: Core : Styles Version: FCKeditor 2.5
Keywords: Review+ Cc:

Description

With the new Style system the FCKConfig.GeckoUseSPAN setting shouldn't affect the output at all, so it can be removed.

Attachments (1)

1607.patch (3.5 KB) - added by Alfonso Martínez de Lizarrondo 12 years ago.
Proposed patch

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1607.patch added

Proposed patch

comment:1 Changed 12 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Milestone: FCKeditor 2.6

I've attached the proposed patch. It removes the configuration entries and initializes the editing mode of Gecko to don't use CSS (we will take care of it).

comment:2 Changed 12 years ago by Martin Kou

Keywords: Review+ added; Review? removed
Resolution: fixed
Status: newclosed

Fixed with [1170].

Click here for more info about our SVN system.

comment:3 Changed 12 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: closedreopened

Is there any reason for still calling the styleWithCSS/useCSS commands? They should make no difference for us.

comment:4 Changed 12 years ago by Alfonso Martínez de Lizarrondo

I've leave them there just in case the code generated by Gecko with CSS differs slightly from what is expected currently and maybe it does something in the future that isn't handled (I'm expecting that they could only change the behavior of StyleWithCSS, changing the output if it is disabled will bring them lots of bug reports quickly).

But if we are confident about the capabilities of the Style system then we can remove them.

comment:5 Changed 12 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: reopenedclosed

According to the Midas documentation, this command defaults to "true". So, other than being irrelevant to us, it is an unneeded "just in case" thing.

Removed with [1176]. I've also removed the "insertBrOnReturn" note from there.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy