Make it possible to use RegisterDoubleClickHandler with any tag

[Alfonso Martínez de Lizarrondo]

Now in order to use the RegisterDoubleClickHandler you must specify the node tags that you want to watch, but it could be better to also be able to register the event listener with any tag (so if you want to have a listener for both span and img you don't have to call it twice, thing get worse if you need to listen to various different elements)

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Alfonso Martínez de Lizarrondo]

The proposed patch includes the suggestion of #1608 and the code to have a generic handler.

to test it I've used this simple code:

function FCKeditor_OnComplete(editorInstance)
{
	editorInstance.RegisterDoubleClickHandler(ClickLinks, 'a');
	editorInstance.RegisterDoubleClickHandler(Everything);
}

function ClickLinks(o)
{
	alert("Link, " + o.nodeName)
}

function Everything(o)
{
	alert("Node, " + o.nodeName)
}

[Martin Kou]

It seems to me that line 289 - 298 might be unsafe, since the reference to oldFunction would be changed and thus at most only two function references can be stored. I might be wrong though.

How about changing it to use an array or an object to store all the event handlers like in FCKEvents? That's the more traditional and time-proven way of implementing a publisher and subscriber pattern.

[Alfonso Martínez de Lizarrondo]

Revised patch

[Alfonso Martínez de Lizarrondo]

The trick in that code was that each new function was wrapping the previous one, so it would work, although I agree that it was far from ideal and should have rewritten it instead of just trying to use directly in the way that it was suggested.

The new patch uses exactly the same code than the FCKEvents.

[Martin Kou]

I've reviewed and tested the patch, and merged it to trunk in [1178].