Opened 12 years ago

Closed 11 years ago

Last modified 9 years ago

#161 closed Bug (worksforme)

Wrong position of toolbar panels for GWT Popups in Firefox

Reported by: Ashish Kumar Sinha <aksinha.iit@…> Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Floating Panel Version: FCKeditor 2.3.2
Keywords: Firefox Cc: ashish.sinha@…

Description

I am using FCKEditor with Google Web Toolkit (GWT). And the floating panels which are popped up if we click on tool bars like Styles or Font etc are being wrongly positioned only if the editor is being used inside a Popup panel or a Dialog box. The GWT Dialogbox/Popup panels also contain scroll bars.

Otherwise it behaves fine, I mean if it is used inside normal browser window, positions of those panels are correct.

FCKEditor : 2.3.2

Build : 1082

GWT Version : 1.1.2

Browser : Firefox/2.0.0.2

OS : Windows XP

Attachments (3)

fckpanel-v2.3.2-AKSinha.js (8.5 KB) - added by Ashish Kumar Sinha <aksinha.iit@…> 12 years ago.
fckpanel.js from FCKEditor 2.3.2. It contains the modifications.
fckpanel-v2.3.2-AKSinha.2.js (2.4 KB) - added by Ashish Kumar Sinha <aksinha.iit@…> 12 years ago.
FCKPanel function from fckpanel.js (v 2.3.2) : Shows the changes that I have made
gwtTest.zip (80.3 KB) - added by Martin Kou 11 years ago.
Test case built with Google Web Toolkit 1.4.61 for Mac OS X Leopard.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 12 years ago by Frederico Caldeira Knabben

Keywords: Firefox added; Toolbar Panel Wrong position GWT Popups removed

Do you have the same results with FCKeditor 2.4 or even the Nightly Build?

Do you think you can attach a zip with GWT and a test case page so we can easily reproduce the problem here (there is no need to include FCKeditor on it, just all the rest)?

Changed 12 years ago by Ashish Kumar Sinha <aksinha.iit@…>

Attachment: fckpanel-v2.3.2-AKSinha.js added

fckpanel.js from FCKEditor 2.3.2. It contains the modifications.

Changed 12 years ago by Ashish Kumar Sinha <aksinha.iit@…>

FCKPanel function from fckpanel.js (v 2.3.2) : Shows the changes that I have made

comment:2 Changed 12 years ago by Ashish Kumar Sinha <aksinha.iit@…>

I have not checked it especially with 2.4 but certainly I have found the same behavior with 2.3.1, 2.3.2 and 2.3.3. But I believe the problem will be with 2.4 as well.

I understand that providing the development team with a zip archive would help a lot but to avail that I will have to go for a parallel implementation in a separate project which may take time.

However, for now I can help like this. I could find a solution to the problem with minor changes in the source code. It has not fixed the problem completely but may explain the nature of the problem.

  1. For gecko browsers, I tried a way so that all position calculations are done with respect to the editor itself. So, I inserted an if statement in the function FCKPanel.js (Please see the attached file which I have taken from v2.3.2). It has fixed the problem for floating panels being popped up through toolbars but the context menu over the editing area is still mis-positioned.
  1. I also increased the default height of the editor to '250' from '200' (in fckeditor.js)
  1. In case, I disable the context menu pop up event from function FCK.InitializeBehaviors then I get the default context menu of the browser, which anyway takes care of the options 'Cut', 'Copy' and 'Paste'.

comment:3 Changed 12 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6

comment:4 Changed 11 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

comment:5 Changed 11 years ago by Martin Kou

I believe the patch written for #1514 also fixes this ticket. I'm still reading the GWT docs to see how I can create a test case for this.

comment:6 Changed 11 years ago by Martin Kou

I've created a pre-built, very simple test case. It seems to work ok with the trunk code.

Changed 11 years ago by Martin Kou

Attachment: gwtTest.zip added

Test case built with Google Web Toolkit 1.4.61 for Mac OS X Leopard.

comment:7 Changed 11 years ago by Martin Kou

The uploaded test case file is an Eclipse project directory that can be imported into Eclipse.

comment:8 Changed 11 years ago by Martin Kou

Resolution: worksforme
Status: assignedclosed

The toolbar panels seem to work ok in my test case, and the bug reporter hasn't made any replies yet, so I'm closing this ticket.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy