Opened 10 years ago

Closed 10 years ago

#1613 closed Bug (fixed)

Extra div wrapping the editor instance

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Review+ Cc:

Description

This is not about the content generated by the editor, but just the HTML that does in fact becomes the editor. The call to FCKeditor.prototype.CreateHtml returns a <div> that wraps some hidden inputs and a iframe or textarea.

From my point of view that div isn't necessary so it could be removed as it makes a little harder to get 100% height in standards mode and doesn't provide anything useful.

Attachments (1)

1613.patch (7.0 KB) - added by Alfonso Martínez de Lizarrondo 10 years ago.
Proposed SVN patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Brian Klug

Comment - this makes sense. I cannot think of any reason to have it.

After all, people can easily wrap the output of CreateHtml with their own DIV, if they really want it.

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

Changed 10 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1613.patch added

Proposed SVN patch

comment:3 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added

The patch does remove the div generated with the different integration methods.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed
Milestone: FCKeditor 2.6

I'm sure this things had some sense in the past. I recall we were used to not have that <div>, but for some reason it has been introduced, in the early beginnings (so, prone to mistakes).

Unfortunately we didn't have SVN to help us explaining anything about it. It makes no sense to me too, so let's drop it.

Please include the changelog entry for it.

comment:5 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [1503]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy