[FF] styles on iframe elements affect the editor and panels

[Alfonso Martínez de Lizarrondo]

Add

	<style type="text/css">
		iframe {
			width: 100%;
			height: 400px;
			border: 3px solid red;
			background-color: blue;
		}
	</style>

to a test page and you'll see that they make impossible to use the editor. I think that we should force some styles on the generated iframes to avoid this kind of problems.

Reported in ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=7759

[Wojciech Olchawa]

Confirmed in FF. Works in IE.

The big occurs in stable 2.5.1 and in the SVN version.

[Wojciech Olchawa]

The *big occurs in stable 2.5.1 and in the SVN version.

• THE BUG :)

[Frederico Caldeira Knabben]

As pointed by Alfonso, the solution for #1948 could be generalized to fix this one too.

[Martin Kou]

I've written a patch such that the editor iframe and floating panels in sample*.html are not longer affected by external styles. However, I've noticed that the changes would touch the integration code in $FCKeditor/fckeditor.<lang> files, and I've only changed the fckeditor.js file for that.

[Martin Kou]

My test case for the page:

        <style type="text/css">
                iframe {
                        width: 500px;
                        height: 400px;
                        border: 3px solid red;
                        background-color: blue;
                        padding: 20px;
                        margin: 20px;
                }
        </style>

[Martin Kou]

I've found a way to reset the styles of the editor iframe without modifying any integration code. The updated patch is ready for review.

[Alfonso Martínez de Lizarrondo]

the

/^\d+$/.test( width ) && ( width += 'px' ) ; 
/^\d+$/.test( height ) && ( height += 'px' ) ; 

code seems too complex, I think that it's easier to understand it this way (if I have understood properly the code)

 if (/^\d+$/.test( width ) ) width += 'px' ; 
 if (/^\d+$/.test( height ) ) height += 'px' ; 

also, instead of naming the variable "sy" you could name it "style", it will be compressed anyway, so there's no need to do it right now.

[Martin Kou]

Updated patch according to suggestions.

[Martin Kou]

Fixed with [1950].

Click here for more info about our SVN system.