Selecting a Format while in a Bulleted/Numbered list fails to make new Bullets/Numbers

[Jon Brooks]

This issue was related to bug 277 which is now fixed.

To Reproduce:

• Create a Bulleted list
• Select 'Heading 2'
• Type some text, hit return

Result:

No new bullets appear. The only way to make new bullets is to position the cursor at the end of the document and create a new bulleted list.

[Jon Brooks]

Additionally, IE has unexpected cursor behavior with these steps:

• Create a Bulleted List
• Type one line of text, hit return
• Select 'Heading 2'

Result: Cursor position jumps to the previous bullet.

[Martin Kou]

Confirmed both bug reports.

[Frederico Caldeira Knabben]

The proposed patch will give a strange effect when loading the following HTML:

<ul>
    <li>
    <h1>Hit ENTER HERE -&gt;&lt;--</h1>
    <p>Line 2</p>
    </li>
</ul>

Then, just hit ENTER in between the arrows.

[Frederico Caldeira Knabben]

Maybe a simple solution for it would be using FCKDomTools.BreakParent() to split the <li> in that case.

Also, right after the proposed patch, there is a "if ( oSplitInfo )" check. Any manipulation using oSplitInfo should be done inside of it.

[Martin Kou]

Updated patch according to Fred's suggestions.

[Frederico Caldeira Knabben]

The proposed patch would be ok (a line could be removed there), but it fails in the following test case (which should have been noted during the patch tests :P):

1. Create a bulletted item.
2. Set format to "Heading 1" to that item.
3. Hit ENTER at the end of that item text.

In IE it throws and error... in FF it does strange things.

It is not any fault in the patch changes though. It is a bug in FCKDomTools.BreakParent. I'll propose a patch for it.

[Frederico Caldeira Knabben]

The proposed patch is much similar to the previous one developed by Martin, but it fixes FCKDomTools.BreakParent.

Actually the bug fells down to FCKW3CRange._ExecContentsAction. It was not working on cases where we have a range like the following (where [ and ] are the range boundaries):

<p><b>Test[</b>]</p>

It was considering the range empty in that case. I've written several tests that helped on properly fixing it.

I'm taking this ticket to myself, so it can be properly reviewed. The fixes proposed by Martin have Review+ for me, so just other things should be reviewed now.

[Frederico Caldeira Knabben]

Fixed with [1714]. Click here for more info about our SVN system.