Opened 2 years ago

Last modified 2 years ago

#16683 confirmed New Feature

Balloonpanel should handle non-existent styles.

Reported by: kkrzton Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

Steps to reproduce

  1. Go to https://www.webtrix.be/moonocolor/ (you can also use build with this or different skin downloaded from http://ckeditor.com/builder).
  2. Switch to source mode and paste html:
<h1>Content Accessibility Matters</h1><p><img src="https://c.cksource.com/ac/2/images/accessibility-matters-01.png" style="float:right" /></p>
  1. Switch back to WYSIWYG mode.
  2. Click a11ychecker button to run Accessibility Checker.

Expected result

The Accessibility Checker dialog opens. It is styled and positioned properly.

Actual result

The Accessibility Checker dialog opens. It is not styled and positioned properly.

Other details (browser, OS, CKEditor version, installed plugins)

The cause of this issue is the fact that balloonpanel has only 3 supported skins (https://github.com/ckeditor/ckeditor-dev/tree/master/plugins/balloonpanel/skins) and for any other skin, invalid CSS is loading (see attached screenshot) so there is no styling applied to ballonpanel (for its insides, which are handled by a11ychecker plugin, the default skin is loaded, which is moono-lisa since 4.6.0).

I think balloonpanel should use default styles if stylesheet for specific skin is not present.

Attachments (1)

Screen Shot 2016-11-21 at 10.36.10.png (28.8 KB) - added by kkrzton 2 years ago.

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by kkrzton

comment:1 Changed 2 years ago by kkrzton

Status: newconfirmed

comment:2 Changed 2 years ago by kkrzton

Version: 4.6.0

The only thing which changed in 4.6.0 is that the balloonpanel was moved as a core plugin. I assume this case might be a problem also in earlier versions.

Last edited 2 years ago by kkrzton (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy