Opened 3 years ago

Closed 3 years ago

#16712 closed Task (invalid)

Remove/Alter MagicLine's use of window.top.DEBUG

Reported by: Robert Flaherty Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

I don't know the history behind this, but only this one plugin makes use of a global, which is stubbed out locally.

I just happened to run into this when I made a global window.DEBUG=true to control all my loading of debug vs. minified scripts through RequireJS. This makes MagicLine fail, as it is expecting an object with methods.

I've changed my variable, but is this code that should be dumped? Or, if it has to stay, change the variable name to something that won't clash, like window.ckDebug.

Change History (1)

comment:1 Changed 3 years ago by Jakub Ś

Keywords: MagicLine DEBUG removed
Resolution: invalid
Status: newclosed
Version: 4.6.0

There is explanation in code - Internal DEBUG uses tools located in the topmost window.

This code is removed in release version so it looks like you are working with the dev code. If that is the case then please name your property different as this code has to stay for debug purposes.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy