Opened 6 months ago

Closed 5 months ago

#16845 closed Bug (fixed)

[IE11] Cursor jump to the top of the editor

Reported by: mencia Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.6.0
Keywords: IE Cc:

Description

Steps to reproduce

  1. Change the editor to the source code mode.
  2. Copy and paste the contents in the attached file.
  3. Change the editor to the WYSIWYG mode.
  4. Scroll down the editor viewport to the bottom.
  5. Left mouse click on the last 'brownie.jpg' image.
  6. Cursor jump to the top of the editor viewport.

Other details (browser, OS, CKEditor version, installed plugins)

[CKEditor version]

[Client OS, Browser]

  • Windows 10 Pro(64bit) / Internet Explorer 11

Attachments (1)

code_for_reproduce.txt (895 bytes) - added by mencia 6 months ago.

Download all attachments as: .zip

Change History (13)

Changed 6 months ago by mencia

Attachment: code_for_reproduce.txt added

comment:1 Changed 6 months ago by mencia

Expected result

The image should be selected.

Actual result

Cursor jump to the top of the editor viewport.

comment:2 Changed 6 months ago by Jakub Ś

Keywords: IE added
Status: newconfirmed
Version: 4.6.24.6.0

Problem can be reproduced from CKEditor 4.6.0 in IE9-11.

comment:3 Changed 6 months ago by Marek Lewandowski

Milestone: CKEditor 4.7.0

comment:4 Changed 6 months ago by Marek Lewandowski

We need to bisect it first to understand when the bug was introduced.

comment:5 Changed 6 months ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:6 Changed 6 months ago by Tade0

Observation: clicking on the image scrolls the editor, while clicking next to it but close enough for the cursor to change into the move icon simply selects the image.

comment:7 Changed 6 months ago by Tade0

Observation: This does not happen in all editor configurations.

There's something special in the way that last image is made.

comment:8 Changed 6 months ago by Tade0

As with any bug of this type opening the dev tools is enough to make it disappear.

comment:9 Changed 6 months ago by Tade0

Bisecting revealed that this is the offending commit: https://github.com/ckeditor/ckeditor-dev/commit/9f97b190fcaab80780e720dd1c7681c60d9f7dea

So apparently there's a problem somewhere in the copyformatting plugin.

comment:10 Changed 6 months ago by Tade0

This particular problem can be solved by setting the focusEditor flag in the applyFormatting command in CF to false.

Unit tests pass - checking if it doesn't break anything else.

comment:11 Changed 6 months ago by Tade0

Status: assignedreview

Checked enough manual tests(especially ones concerning focus) to be confident that nothing has been broken by this change.

Added manual test.

Changes pushed to branch:t/16845.

comment:12 Changed 5 months ago by Tomasz Jakut

Resolution: fixed
Status: reviewclosed

LGTM. Merged with git:a4e9eef.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy