Opened 6 months ago

Closed 6 months ago

Last modified 3 months ago

#16850 closed New Feature (fixed)

Custom context menu disable option

Reported by: Marek Lewandowski Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.7.0
Keywords: Cc:

Description (last modified by Marek Lewandowski)

We need an option to disable our custom context menu, even if the plugin is loaded. The thing is that contextmenu plugin is required by plugins like tabletools or liststyle, where it's the only way to see the features added by the plugin.

If we'd remove it from required property, this plugin would not be automatically picked by our online builder, so that's a no-go.

But some customers provide custom implementation of UI, where custom context menu is not needed.

Change History (12)

comment:1 Changed 6 months ago by Marek Lewandowski

Status: newconfirmed

comment:2 Changed 6 months ago by Marek Lewandowski

Description: modified (diff)

comment:3 Changed 6 months ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:4 Changed 6 months ago by Tade0

Status: assignedreview

Added a configuration option that simply prevents the context menu from opening.

comment:5 Changed 6 months ago by Tomasz Jakut

Status: reviewreview_failed

Fix LGTM, however there's no unit test. It should be easy to write one (probably it would be enough to check if open calls menu's show method).

comment:6 Changed 6 months ago by Tade0

Status: review_failedreview

Added unit tests.

Changes pushed to branch:t/16850.

comment:7 Changed 6 months ago by Tomasz Jakut

Status: reviewreview_failed

Actually, after second thoughts, I think that it would be better to have option not for disabling context menu but for enabling it. I did a quick research in our docs and found that we have at least 4 config variables with "enable" in name and 0 with "disable". There are also some similar cases, e.g. resize_enabled.

comment:8 Changed 6 months ago by Tade0

Status: review_failedreview

That's true, but the problem here is that to date the context menu was always enabled and worked out of the box - this is how most users expect it to work now.

The idea behind this feature is that some users want to have other features enabled that normally require the contextmenu plugin, but don't want to have the context menu itself.

EDIT: I see what you mean now. Changing accordingly.

Last edited 6 months ago by Tade0 (previous) (diff)

comment:9 Changed 6 months ago by Tade0

Fixed, rebased with major.

Changes pushed to branch:t/16850.

comment:10 Changed 6 months ago by Tomasz Jakut

Resolution: fixed
Status: reviewclosed

LGTM. Merged with git:56e6fda.

comment:11 Changed 4 months ago by Marek Lewandowski

Summary: Context menu disable optionCustom context menu disable option

comment:12 Changed 3 months ago by Marek Lewandowski

Description: modified (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy