Custom context menu disable option

[Marek Lewandowski]

We need an option to disable our custom context menu, even if the plugin is loaded. The thing is that contextmenu plugin is required by plugins like tabletools or liststyle, where it's the only way to see the features added by the plugin.

If we'd remove it from required property, this plugin would not be automatically picked by our online builder, so that's a no-go.

But some customers provide custom implementation of UI, where custom context menu is not needed.

[Tade0]

Added a configuration option that simply prevents the context menu from opening.

[Tomasz Jakut]

Fix LGTM, however there's no unit test. It should be easy to write one (probably it would be enough to check if open calls menu's show method).

[Tade0]

Added unit tests.

Changes pushed to ​branch:t/16850.

[Tomasz Jakut]

Actually, after second thoughts, I think that it would be better to have option not for disabling context menu but for enabling it. I did a quick research in our docs and found that we have at least 4 config variables with "enable" in name and 0 with "disable". There are also some similar cases, e.g. ​resize_enabled.

[Tade0]

That's true, but the problem here is that to date the context menu was always enabled and worked out of the box - this is how most users expect it to work now.

The idea behind this feature is that some users want to have other features enabled that normally require the contextmenu plugin, but don't want to have the context menu itself.

EDIT: I see what you mean now. Changing accordingly.

[Tade0]

Fixed, rebased with major.

Changes pushed to ​branch:t/16850.

[Tomasz Jakut]

LGTM. Merged with ​git:56e6fda.