#16857 closed Bug (fixed)
Ctrl + Shift + V blocked by copy formatting
| Reported by: | Wiktor Walc | Owned by: | kkrzton |
|---|---|---|---|
| Priority: | Nice to have (we want to work on it) | Milestone: | CKEditor 4.7.0 |
| Component: | General | Version: | 4.6.0 |
| Keywords: | Cc: |
Description (last modified by )
Steps to reproduce
- Open "Document Editor" sample on ckeditor.com.
- Copy something, e.g. a part of a header.
- Press Ctrl + Shift + V to paste clipboard as plain text.
Expected result
Text is pasted.
Actual result
Text is not pasted.
Other details (browser, OS, CKEditor version, installed plugins)
We'd like implement this in a way that CTRL+SHIFT+V will paste formatting only if it has been activated with CTRL+SHIFT+C - so that the Copy Formatting icon is active, and the toolbar button shows "pressed" state.
If copy formatting is not active, then this hotkey will paste as plain text.
This will improve interoperability with apps like MS Word, which use exact same hotkey, while keeping the original paste as plain text hotkey for people that doesn't use copy formatting.
Issue caused by copy formatting using keyboard shortcut which is usually used to paste plain text browsers.
Change History (7)
comment:1 Changed 8 years ago by
| Milestone: | → CKEditor 4.7.0 |
|---|---|
| Priority: | Normal → Nice to have (we want to work on it) |
| Status: | new → confirmed |
comment:2 Changed 8 years ago by
| Owner: | set to Tade0 |
|---|---|
| Status: | confirmed → review |
comment:3 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed with git:caa3bcb3c2.
comment:4 Changed 8 years ago by
| Description: | modified (diff) |
|---|
comment:5 Changed 8 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
This fix no longer works after #16954, which surfaced underlying issue, that multiple command can not be hooked assigned to the same keystroke.
comment:6 Changed 8 years ago by
| Owner: | changed from Tade0 to kkrzton |
|---|---|
| Status: | reopened → review |
comment:7 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Rebased and merged (ff) using github. Diff available at https://github.com/ckeditor/ckeditor-dev/pull/341/files.
Solution was to return false after putting screen reader message that applying failed.
This way the keystroke handler knows not to prevent the default behaviour which is pasting plain text.
Changes pushed to branch:t/16857.