#16937 closed New Feature (fixed)

[API] getCommandKeystroke should also accept command name as argument

Reported by: Marek Lewandowski Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.7.0
Component: UI : Widgets Version: 4.7.0
Keywords: Cc:

Description

Currently getCommandKeystroke accepts only Command instance as an argument. This is different from the most editor methods like execCommand, addCommand and so on.

Thus first parameter add support also accept string type.

Remember about docs, to mention that String support was added in 4.7.0.

Change History (4)

comment:1 Changed 19 months ago by Marek Lewandowski

Status: newconfirmed

comment:2 Changed 19 months ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:3 Changed 19 months ago by kkrzton

Status: assignedreview

Changes in t/16937.

comment:4 Changed 19 months ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed
  • Avoid duplicating expected value in assertion messages, as it's error-prone later on when someone changes expected value but doesn't check and update the assertion message.
  • We're using / rather than pipe `|` character as a separator for types in API docs.

I fixed these minor issues, I also added returned type docs.

Fixed in git:da7d4f1a26, merged to major.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy