IE : Loop while formatting Word pasted data

[Luis]

Hi,

I´m getting this bug since release 2.5, aparentely due to a javascript loop on text format commands. The page freezes and returns a message asking me to stop the script that is taking too long to run. That also happens on the demo page for this site when you put a long text (it doesn´t need to be that long), containing paragraphs with different text formats, select it all and try to do any formatting with it, such as right aligning.

I´m using Internet Explorer 6.0 and Windows XP.

Hope you find a solution on that enableing me to upgrade FCKEditor, solving most of the problems I have on the previous versions.

Thanks,

Luís

[Luis]

Sample Data and Screenshot

[Frederico Caldeira Knabben]

Confirmed with IE. No problem with other browsers.

I've reduced the TC for it:

1. Load the following HTML:

<p><b>SAMPLE DATA<o:p></o:p></b></p>

2. Align the "SAMPLE DATA" paragraph to right.

The browser will loop.

It works well by removing the <b> or the MS Office <o:p> tags.

[Luis]

Remember that it also happens when you write text with lots of paragraphs, containing different formats, straight on fckeditor. It´s not necessarily a pasted data from word. Thanks again, Luís

[Frederico Caldeira Knabben]

Replying to oliveira_lcs:

Remember that it also happens when you write text with lots of paragraphs, containing different formats, straight on fckeditor. It´s not necessarily a pasted data from word.

For that case Luis, we need the precise steps to reproduce it. We can only work on facts, not theories.

Thanks for the update.

[Luis]

You´re right. That happened to me on 2.5. I´ve tried to reproduce it on the actual demo page without success, so maybe it´s fixed for 2.5.1. Thank you and I hope you find a solution for the word pasted data soon.

[Carlos Hespanhol]

I found that it get in a loop at "while ( ( block = iterator.GetNextParagraph() ) )" in fckjustifycommands.js.

iterator.GetNextParagraph() keeps returning <B></B> while variable currentnode in function GetNextParagraph() have <B><?xml:namespace prefix = o /><o:p></o:p></B>

I guess it is a matter of deleting the empty tag <B></B> at the end of the function, I just dont know how to do it.

[Martin Kou]

Proposed patch for fixing #1707.

[Martin Kou]

Simplified patch for fixing #1707.

[Frederico Caldeira Knabben]

Please include the changelog entry when committing.

[Martin Kou]

Fixed with [1409].

Click here for more info about our SVN system.

[Luis]

I just tested with the changed file and it still freezes while formatting. Guess it needs to be reviwed. Thank you once again, Luís

[Martin Kou]

Hi Luís,

Did you apply the patch to our released source package or to the SVN source tree? I'm asking this because applying the patch to the release source package has no effect - the source code in the downloadable package is there for viewing purpose only, it is not loaded by the browser. The patch is only effective if you apply it to the SVN source tree.

[Frederico Caldeira Knabben]

You may also try our nightly build.

[Frederico Caldeira Knabben]

I've tested it with both the reported TC as well as with the reduced TC described in comment:1. It works for me on both cases.

Feel free to reopen it if it is still a problem. In that case, please provide the precise instructions to reproduce it.

[Luis]

It did work for the nightly build. Thank you!!!