Opened 17 years ago
Closed 17 years ago
#1769 closed New Feature (fixed)
Improvements to FCKDomTools.GetCurrentElementStyle
| Reported by: | Frederico Caldeira Knabben | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Review+ | Cc: |
Description
I'm attaching a patch with the following improvements for FCKDomTools.GetCurrentElementStyle:
- There is no need to pass the window in the parameters (this was a Firefox requirement only).
- Due to the above, FCKDomTools.GetPositionedAncestor is not required to receive the window in the parameters too.
- Using the getPropertyValue method to retrieve the property value, instead of the default indexer access.
- In CSS we have "properties", not attributes, so the parameter name could be fixed.
Attachments (1)
Change History (4)
Changed 17 years ago by
| Attachment: | 1769.patch added |
|---|
comment:1 Changed 17 years ago by
| Keywords: | Review? added |
|---|---|
| Status: | new → assigned |
comment:2 Changed 17 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:3 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [1384]. Click here for more info about our SVN system.
Note: See
TracTickets for help on using
tickets.
It looks better this way