Opened 10 years ago

Closed 10 years ago

#1782 closed Bug (fixed)

Freeze of whole IE-window when clicking radiobutton

Reported by: John van der Elburg Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.5.1
Keywords: Confirmed IE Review+ Cc:

Description

The code in the attached file produces a page with an fckeditor that freezes the whole IE window when you click on the radio button inside it. This occurs when you click the radio button while the focus is NOT in the fckeditor window. It also happens with checkboxes.

You can test it on http://faramir.proteon.nl/fcktest.html

This didn't happen in fckeditor 2.4.3, but happens in both fckeditor 2.5 and 2.5.1.

Browser: IE7 on Windows XP.

Attachments (3)

fcktest.html (1.2 KB) - added by John van der Elburg 10 years ago.
Example file
1782.patch (2.4 KB) - added by Martin Kou 10 years ago.
1782_2.patch (1.7 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by John van der Elburg

Attachment: fcktest.html added

Example file

comment:1 Changed 10 years ago by Wojciech Olchawa

Keywords: Confirmed IE7 added
Version: FCKeditor 2.5.1

comment:2 Changed 10 years ago by Martin Kou

Milestone: FCKeditor 2.6
Owner: set to Martin Kou
Status: newassigned

comment:3 Changed 10 years ago by Martin Kou

This bug is pretty severe so I'm targetting it to 2.6.

Changed 10 years ago by Martin Kou

Attachment: 1782.patch added

comment:4 Changed 10 years ago by Martin Kou

Keywords: Review? added; Confirmed IE7 removed

comment:5 Changed 10 years ago by Martin Kou

The problem seems to come from IE instead of FCKeditor's code. What happened was when the radio button or checkbox in the editable area was clicked after the textbox was focused, IE somehow locked the mouse focus to the clicked button and couldn't release it unless you took the focus away from the IE window.

The solution in my patch was to make the radio button or checkbox temporarily disabled when it is being clicked. The trick seems to stop IE from locking the mouse focus on the said widgets.

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed IE added

comment:7 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 1782_2.patch added

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

Martin, you are really good for finding those hacks. I've just changed your original patch a bit:

  • It does everything in fck_ie.js.
  • It simplified the logic a bit, as there is no need to do anything if the <input> element is already disabled.
  • I've reduced the timeout to re-enable the element to just 1ms. I noted a small flashing change with the original 50ms. 1ms seems to work, but if you have a precise motivation for 50ms, then feel free to revert it.
  • The function names have been generalized (for possible reuse) according to the names already in use. I'm not saying that I like "Doc_OnMouseDown", but that's the way we have the code now. We'll have our chance to change it in the future (V3).

If you fell it is ok, go ahead committing it.

comment:9 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:10 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [1467].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy