Opened 17 years ago
Closed 17 years ago
#1782 closed Bug (fixed)
Freeze of whole IE-window when clicking radiobutton
Reported by: | John van der Elburg | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | FCKeditor 2.6 |
Component: | General | Version: | FCKeditor 2.5.1 |
Keywords: | Confirmed IE Review+ | Cc: |
Description
The code in the attached file produces a page with an fckeditor that freezes the whole IE window when you click on the radio button inside it. This occurs when you click the radio button while the focus is NOT in the fckeditor window. It also happens with checkboxes.
You can test it on http://faramir.proteon.nl/fcktest.html
This didn't happen in fckeditor 2.4.3, but happens in both fckeditor 2.5 and 2.5.1.
Browser: IE7 on Windows XP.
Attachments (3)
Change History (13)
Changed 17 years ago by
Attachment: | fcktest.html added |
---|
comment:1 Changed 17 years ago by
Keywords: | Confirmed IE7 added |
---|---|
Version: | → FCKeditor 2.5.1 |
comment:2 Changed 17 years ago by
Milestone: | → FCKeditor 2.6 |
---|---|
Owner: | set to Martin Kou |
Status: | new → assigned |
Changed 17 years ago by
Attachment: | 1782.patch added |
---|
comment:4 Changed 17 years ago by
Keywords: | Review? added; Confirmed IE7 removed |
---|
comment:5 Changed 17 years ago by
The problem seems to come from IE instead of FCKeditor's code. What happened was when the radio button or checkbox in the editable area was clicked after the textbox was focused, IE somehow locked the mouse focus to the clicked button and couldn't release it unless you took the focus away from the IE window.
The solution in my patch was to make the radio button or checkbox temporarily disabled when it is being clicked. The trick seems to stop IE from locking the mouse focus on the said widgets.
comment:6 Changed 17 years ago by
Keywords: | Confirmed IE added |
---|
comment:7 Changed 17 years ago by
Keywords: | Review- added; Review? removed |
---|
Changed 17 years ago by
Attachment: | 1782_2.patch added |
---|
comment:8 Changed 17 years ago by
Keywords: | Review? added; Review- removed |
---|
Martin, you are really good for finding those hacks. I've just changed your original patch a bit:
- It does everything in fck_ie.js.
- It simplified the logic a bit, as there is no need to do anything if the <input> element is already disabled.
- I've reduced the timeout to re-enable the element to just 1ms. I noted a small flashing change with the original 50ms. 1ms seems to work, but if you have a precise motivation for 50ms, then feel free to revert it.
- The function names have been generalized (for possible reuse) according to the names already in use. I'm not saying that I like "Doc_OnMouseDown", but that's the way we have the code now. We'll have our chance to change it in the future (V3).
If you fell it is ok, go ahead committing it.
comment:9 Changed 17 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:10 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [1467].
Click here for more info about our SVN system.
Example file