Opened 12 years ago

Closed 12 years ago

#1789 closed New Feature (wontfix)

Avoid using IE6 dialog js file in skins

Reported by: Scott McNaught Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: SVN (FCKeditor) - Retired
Keywords: Cc:

Description

Is there a good reason why there is an IE 6 compatibility javascript file in the skins folder?

From a user with my own skin, I would prefer it if there was no script in the skins folder, because it concerns me when its time to upgrade. It would be something that id forget about.

Do we really need it?

Change History (1)

comment:1 Changed 12 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Dialogs
Milestone: FCKeditor 2.6
Priority: HighNormal
Resolution: wontfix
Status: newclosed
Summary: IE6 DIalog JS file in SkinsAvoid using IE6 dialog js file in skins
Type: BugNew Feature
Version: SVN

The js file for IE6 is required for all skins as of [1398]. Its contents are skin dependent, not generic. It can be blank for example, but it is most likely to have some code.

The fact is that we are using many absolute positioning features in the new dialog design, and some of them don't work properly with IE6-. So, we need to fix those things by code in such cases, and it must be done on window startup and resize.

Having a single standard file (outside the skin folders) would not work as each skin has it's own needs and measures. Ok, the three skins we provide all share the same structure, but it doesn't mean that a custom skin could not have a completely different design and dimensions.

Once you have defined this js file for your skin, you will not have to upgrade its contents when upgrading the editor as its contents are not supposed to change. Of course, as long as the dialog system don't suffer further changes, which would require reviewing custom skins in any case.

Unfortunately we didn't find other ways to workaround those IE6 limitations. Feel free to reopen this ticket if you have suggestions in this sense.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy