Opened 11 years ago

Closed 10 years ago

#180 closed Bug (fixed)

Backwards compatibility with older PHP versions

Reported by: pmeems@… Owned by: Wiktor Walc
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: Server : PHP Version:
Keywords: SF Cc:

Description

I use v2.3.1 and I only got it to work after added several lines of codes to let it work not only with $_GET but also with $HTTP_GET_VARS. This also is for $_FILES, $_POST, etc.

I use this code:

global $HTTP_GET_VARS;
if (!isset($_GET))
    $_GET = &$HTTP_GET_VARS;

This prevent my from upgrading to the latest version because I have to go trough all code again.

It would be nice if in the future release this could be solved.

--
Paul


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1603204&group_id=75348&atid=543653

Change History (7)

comment:1 Changed 11 years ago by Frederico Caldeira Knabben

Reporter: changed from Frederico Caldeira Knabben to pmeems@…

comment:2 Changed 11 years ago by Frederico Caldeira Knabben

It would be nice if you could point us to the lines to be changes, or at least attach a zip with all files that you have changed, so we can make a comparison with the original files published with the 2.3.1.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.5

comment:4 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Is it worth trying to fix problems with old versions of PHP?

Recently the news was the plans to drop support for PHP4 and how applications developers and ISP hostings are promising to don't care for PHP4 after February of 2008, http://gophp5.org/ so now adding more code to fix problems for a few people that isn't upgrading to even php4 seems like a backward step with regards to the rest of the community.

I'm not advocating to deliberately drop support and remove the php4 files, but having to spend time testing and trying to fix problems in a version (<4) that isn't supported anywhere else looks like a wrong use of our little time.

If someone steps in and provides the patches, and those patches don't bring problems for the current versions, that would be different.

As well as we might have to drop support for old Netscape and Mozilla versions one day to get rid of several hops and ugly code, we should also make a decision about the minimum requirements for the integration files that we deliver (everyone is free to write their own)

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Owner: Frederico Caldeira Knabben deleted

comment:6 Changed 10 years ago by Wiktor Walc

Owner: set to Wiktor Walc
Status: newassigned

comment:7 Changed 10 years ago by Wiktor Walc

Resolution: fixed
Status: assignedclosed

Fixed with [677]. PHP 4.0 is as far as we can go.

PHP3 has no suport for foreach loops, === and !== operators, doesn't have tons of important functions etc.

However, I hope PHP4 wil disappear from market soon...

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy