Opened 10 years ago

Closed 10 years ago

#1853 closed Bug (fixed)

ShiftEnterMode don't work

Reported by: datalink Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Enter Key Version: FCKeditor 2.5.1
Keywords: Confirmed Review+ Cc:

Description

With

FCKConfig.EnterMode = 'br' ;
FCKConfig.ShiftEnterMode = 'p' ; (or same on 'div')

Shift + Enter make <br>

Attachments (2)

1853.patch (1.5 KB) - added by Martin Kou 10 years ago.
1853_2.patch (2.8 KB) - added by Martin Kou 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by Wojciech Olchawa

Keywords: Confirmed added

Confirmed with IE, IE7 and FF2

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6

Currently it's throwing an error:

eNextBlock has no properties
http://localhost/fckdev/editor/_source/classes/fckenterkey.js
Line 421

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

:|

I'm not able to reproduce it. Tested with IE7 and FF2, with both the SVN and 2.5.1 versions, using sample01.html with the setting changed manually in the fckconfig.js file.

Is it just me? Are there are precise steps to make this error happen?

comment:4 Changed 10 years ago by Martin Kou

Works perfectly for me as well.

comment:5 Changed 10 years ago by Martin Kou

Resolution: worksforme
Status: newclosed

I've done some more tests today and I wasn't able to reproduce the issue.

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: worksforme
Status: closedreopened

I'm able to reproduce it with FF2 in the nightly build with sample12.

comment:7 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: reopenednew

Changed 10 years ago by Martin Kou

Attachment: 1853.patch added

comment:8 Changed 10 years ago by Martin Kou

Keywords: Review? added

comment:9 Changed 10 years ago by Alfonso Martínez de Lizarrondo

#1839 has been marked as dup

comment:10 Changed 10 years ago by Martin Kou

Keywords: Review? removed

Retracted the review request as a better approach was discovered during a conversion with Fred today.

Changed 10 years ago by Martin Kou

Attachment: 1853_2.patch added

comment:11 Changed 10 years ago by Martin Kou

Keywords: Review? added

comment:12 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:13 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [1729].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy