Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1908 closed Bug (fixed)

HtmlEncodeOutput unescapes incorrectly on some strings

Reported by: Aaron Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6.1
Component: Server : ASP.Net Version: SVN (FCKeditor) - Retired
Keywords: HasPatch Review+ Cc:

Description (last modified by Alfonso Martínez de Lizarrondo)

In FCKeditor.LoadPostData() the code that handles reverting the HtmlEncodeOutput changes does not work properly for strings that contain "&amp;lt;" or "&amp;gt;". The current code replaces '&amp;' before '&lt;' and '&gt;' which causes the strings mentioned to be converted to '<' and '>' respectively. What should happen is that the '&amp;' replacement should happen after the '&lt;' and '&gt;' replacement. This allows the strings to be converted to '&lt;' and '&gt;' which I believe is the proper decoding.

Here is a patch that fixes this problem.

Index: FCKeditor.cs
===================================================================
--- FCKeditor.cs        (revision 1585)
+++ FCKeditor.cs        (working copy)
@@ -456,9 +456,9 @@
                        // Revert the HtmlEncodeOutput changes.
                        if ( this.Config["HtmlEncodeOutput"] != "false" )
                        {
-                               postedValue = postedValue.Replace( "&amp;", "&" ) ;
                                postedValue = postedValue.Replace( "&lt;", "<" ) ;
                                postedValue = postedValue.Replace( "&gt;", ">" ) ;
+                               postedValue = postedValue.Replace("&amp;", "&");
                        }

                        if ( postedValue != this.Value )

Attachments (1)

1908.patch (563 bytes) - added by Alfonso Martínez de Lizarrondo 10 years ago.
Patch as a file

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Wojciech Olchawa

Keywords: HasPatch added

Changed 10 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1908.patch added

Patch as a file

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Description: modified (diff)
Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

I've attached the proposed patch for review. I'm not sure about the current released version of FCKeditor.net, so I haven't changed the what's new file

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed
Milestone: FCKeditor 2.6.1

I've appended a new version to the changelog file with [2021]. Feel free to use that for this ticket.

comment:4 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [2024]

Thanks acolwell.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

#2225 has been marked as DUP.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy