Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#191 closed Bug (fixed)

FF Mac: scrollable combos have no scrollbar

Reported by: liane@… Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Toolbar Version: FCKeditor 2.4
Keywords: Review+ Cc:

Description

Firefox 1.507 and 2.0
Mac OSX 10.4.8

Scrollable combos (format, size) have no scrollbar. They can still be scrolled using the mouse wheel, but that is tricky on a iBook...

Works fine on windows.

See attached image.


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1586670&group_id=75348&atid=543653

Attachments (3)

FF-combo-scroll.jpg (15.0 KB) - added by Frederico Caldeira Knabben 10 years ago.
screenshot mac vs windows - Moved from SF. Original author: liane
191.patch (733 bytes) - added by Martin Kou 10 years ago.
Proposed patch for fixing #191.
191_2.patch (1.5 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

update: this behavior only appears when the editor is created inside a div with style="display:none"


Moved from SF. Original poster: liane

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

up: this is triggered also by hiding and showing the editor *after* it has been created, so it is not only related to it being created hidden (004.html in _testcases exhibits this bug, when you click the "Show Editor" button)

Hiding and showing parts dynamically is common practice with modern web applications, and not having a scrollbar makes users think there's nothing more to choose from (that's how I looked at this issue, using the mouse wheel, I didn't even noticed the scrollbar wasn't there).

I hope someone can think of a work-around.


Moved from SF. Original poster: liane

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Reporter: changed from Frederico Caldeira Knabben to liane@…

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: FF-combo-scroll.jpg added

screenshot mac vs windows - Moved from SF. Original author: liane

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed Firefox Mac added
Version: FCKeditor 2.4

Confirmed with FF2. As described, it is reproducible only with _testcases/004.html. The normal samples doesn't show this behavior.

Certainly a FF bug... quite weird though, and therefore difficult to fix.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: CantFix added
Milestone: FCKeditor 2.6

I don't see many chances to fix it at our side. I'm targeting it to the 2.6, so we can properly report the bug at Bugzilla.

comment:6 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 10 years ago by Martin Kou

Attachment: 191.patch added

Proposed patch for fixing #191.

comment:7 Changed 10 years ago by Martin Kou

Keywords: Review? added; SF Confirmed Firefox Mac CantFix removed

I found a kludge that seems to fix the issue on Mac OS X 10.5.1 + Firefox 2.0.0.11.

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

That one was good Martin. I would never arrive to it. There are just some minor things that could be enhanced in the code. I will be attaching an updated patch to it.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 191_2.patch added

comment:9 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

The proposed patch doesn't use the "me" hack by making use of the FCKTools.RunFunction function. It also limits the kludge execution to FF on Mac only, to avoid unneeded stuff on Windows.

Feel free to review it Martin, committing it directly if it sounds good.

comment:10 Changed 10 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:11 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [1387].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy